Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlainText in heading hook for multiline titles does not preserve the newlines #13410

Closed
bep opened this issue Feb 17, 2025 · 0 comments
Closed

PlainText in heading hook for multiline titles does not preserve the newlines #13410

bep opened this issue Feb 17, 2025 · 0 comments
Assignees
@bep
Labels
Bug
Milestone
v0.144.0

Comments

@bep
Copy link
Member

bep commented Feb 17, 2025 

---
title: "p1"
---

First line.
Second line.
----------------

Gives PlainText => First line.Second line..

I didn't even know that multiline titles (without <br>) was even possible in CommonMark before yesterday, so I'm guessing this isn't a widespread issue.
@bep bep self-assigned this Feb 17, 2025
@bep bep removed the NeedsTriage label Feb 17, 2025
@bep bep added this to the v0.144.0 milestone Feb 17, 2025
bep added a commit to bep/hugo that referenced this issue Feb 17, 2025
@bep
Fix auto generated header ids so they don't contain e.g. hyperlink de…
af2bbe7 
…stinations (note)

This makes the header ids match the newly added dt ids.

Also make sure newlines are preserved in hooks' `.PlainText`.

Fixes gohugoio#13405
Fixes gohugoio#13410
@bep bep closed this as completed in 24cc255 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bep bep

Labels
Bug
Projects
None yet
Milestone
v0.144.0
Development

No branches or pull requests
1 participant
@bep