Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim trailing newlines for normal blockquotes too, to mirror callout blockquotes #13302

Closed
Winterhuman opened this issue Jan 24, 2025 · 3 comments · Fixed by #13306
Closed

Trim trailing newlines for normal blockquotes too, to mirror callout blockquotes #13302

Winterhuman opened this issue Jan 24, 2025 · 3 comments · Fixed by #13306
Assignees
Milestone

Comments

@Winterhuman
Copy link

What version of Hugo are you using (hugo version)?

hugo v0.142.0+extended+withdeploy linux/amd64 BuildDate=unknown

Description

Related: #13301

Currently, trailing newlines are removed from blockquotes with callouts, but are kept for normal blockquotes, e.g.

<blockquote>
	<p>Example</p>

</blockquote>

<blockquote>
	<p>Example</p>
</blockquote>

This is slightly confusing (in that sense that it's unintuitive why they'd differ), even if easy enough to mitigate by reimplementing the trimming in the render-blockquotes.html file, so it'd be nice if both types of blockquotes mirrored each other for more consistent HTML output. It's pretty minor, but without a built-in way to prettify HTML in Hugo (related issue: #7190), it is something users will need to keep in mind when wanting to achieve clean & mostly reproducible output

@Winterhuman
Copy link
Author

Winterhuman commented Jan 24, 2025

Apologies in advance if this is more a proposal; I wasn't sure if the fact the behaviour was different in the past would make it count as a bug or an enhancement

@jmooring jmooring added Proposal and removed Bug labels Jan 24, 2025
@jmooring
Copy link
Member

Accepting this proposal.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants