Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check images.Mask's cache key vs the mask supplied #13273

Closed
bep opened this issue Jan 16, 2025 · 1 comment · Fixed by #13274
Closed

Check images.Mask's cache key vs the mask supplied #13273

bep opened this issue Jan 16, 2025 · 1 comment · Fixed by #13274
Assignees
@bep
Labels
Bug Outdated

Comments

@bep
Copy link
Member

bep commented Jan 16, 2025

See #13272 (comment)
@bep bep self-assigned this Jan 16, 2025
@bep bep removed the NeedsTriage label Jan 16, 2025
bep added a commit to bep/hugo that referenced this issue Jan 16, 2025
@bep
resources: Fix 2 image file cache key issues
f04e78d 
* Always include the content hash in the cache key.
* Always include the image config hash in the cache key.

Fixes gohugoio#13273
Fixes gohugoio#13272
@bep bep mentioned this issue Jan 16, 2025
Merged
1 task
bep added a commit to bep/hugo that referenced this issue Jan 17, 2025
@bep
resources: Fix 2 image file cache key issues
843c1dc 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes gohugoio#13273
Fixes gohugoio#13272
bep added a commit to bep/hugo that referenced this issue Jan 17, 2025
@bep
resources: Fix 2 image file cache key issues
03aa5a6 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes gohugoio#13273
Fixes gohugoio#13272
bep added a commit to bep/hugo that referenced this issue Jan 17, 2025
@bep
resources: Fix 2 image file cache key issues
acfea29 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes gohugoio#13273
Fixes gohugoio#13272
bep added a commit to bep/hugo that referenced this issue Jan 17, 2025
@bep
resources: Fix 2 image file cache key issues
9f601b0 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes gohugoio#13273
Fixes gohugoio#13272
bep added a commit to bep/hugo that referenced this issue Jan 17, 2025
@bep
resources: Fix 2 image file cache key issues
99965de 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes gohugoio#13273
Fixes gohugoio#13272
bep added a commit to bep/hugo that referenced this issue Jan 18, 2025
@bep
resources: Fix 2 image file cache key issues
2b259d0 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes gohugoio#13273
Fixes gohugoio#13272
bep added a commit that referenced this issue Jan 18, 2025
@bep
resources: Fix 2 image file cache key issues
1f5a15a 
* Always include the content hash in the cache key for unprocessed images.
* Always include the image config hash in the cache key.

This is also a major cleanup/simplification of the implementation in this area.

Note that this, unfortunately, forces new hashes/filenames for generated images.

Fixes #13273
Fixes #13272
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resources: Fix 2 image file cache key issues bep/hugo
1 participant
@bep