Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Update fr-fr-lang.json (#21082) #21097

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Oct 25, 2024

Updated untranslated French strings

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Updated untranslated French strings

Signed-off-by: tostt <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.12.0@b11237c). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21097   +/-   ##
=================================================
  Coverage                  ?   66.09%           
=================================================
  Files                     ?     1049           
  Lines                     ?   114649           
  Branches                  ?     2867           
=================================================
  Hits                      ?    75774           
  Misses                    ?    34731           
  Partials                  ?     4144           
Flag Coverage Δ
unittests 66.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev
Copy link
Member

@thcdrt can you verify these as well please :)

@wy65701436 wy65701436 changed the title Update fr-fr-lang.json (#21082) [cherry-pick] Update fr-fr-lang.json (#21082) Oct 25, 2024
@wy65701436 wy65701436 merged commit b3dab7a into goharbor:release-2.12.0 Oct 25, 2024
14 of 15 checks passed
@OrlinVasilev
Copy link
Member

@wy65701436 were these double checked ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants