Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the log level from warning to debug to avoid noise when there … #21034

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

stonezdj
Copy link
Contributor

…are many unused ldap groups for each user

fixes #20038

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…are many unused ldap groups for each user

  fixes goharbor#20038

Signed-off-by: stonezdj <[email protected]>
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.09%. Comparing base (c8c11b4) to head (126ba82).
Report is 295 commits behind head on main.

Files with missing lines Patch % Lines
src/core/auth/ldap/ldap.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21034       +/-   ##
===========================================
+ Coverage   45.36%   66.09%   +20.72%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114602   +101269     
  Branches     2719     2856      +137     
===========================================
+ Hits         6049    75749    +69700     
- Misses       6983    34711    +27728     
- Partials      301     4142     +3841     
Flag Coverage Δ
unittests 66.09% <0.00%> (+20.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/auth/ldap/ldap.go 37.45% <0.00%> (ø)

... and 1287 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit ab3d350 into goharbor:main Oct 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

harbor warns about not getting groups excluded by ldap group base dn
6 participants