Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make distribution_src configurable #20769

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Jul 24, 2024
@MinerYang MinerYang requested a review from a team as a code owner July 24, 2024 05:59
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.25%. Comparing base (c8c11b4) to head (066cccd).
Report is 244 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20769      +/-   ##
==========================================
+ Coverage   45.36%   46.25%   +0.88%     
==========================================
  Files         244      247       +3     
  Lines       13333    13778     +445     
  Branches     2719     2845     +126     
==========================================
+ Hits         6049     6373     +324     
- Misses       6983     7073      +90     
- Partials      301      332      +31     
Flag Coverage Δ
unittests 46.25% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 assigned zyyw and unassigned Vad1mo and AllForNothing Jul 24, 2024
@MinerYang MinerYang force-pushed the add_distributionsrc_para branch from 80585ce to 066cccd Compare July 24, 2024 08:06
@MinerYang MinerYang enabled auto-merge (squash) July 24, 2024 08:06
@MinerYang MinerYang merged commit 2dd029e into goharbor:main Jul 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants