feat: bump mockery and switch to generate by config file #20742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20742 +/- ##
===========================================
+ Coverage 45.36% 66.24% +20.87%
===========================================
Files 244 1045 +801
Lines 13333 113501 +100168
Branches 2719 2845 +126
===========================================
+ Hits 6049 75192 +69143
- Misses 6983 34202 +27219
- Partials 301 4107 +3806
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
approved these changes
Jul 15, 2024
|
cc @reasonerjt |
The packages feature in mockery is the new way for managing mocks, and will be the only way to generate mocks in v3. see https://vektra.github.io/mockery/v2.43/migrating_to_packages/. 1. Bump mockery to v2.43.2. 2. Switch the generation from old way to configuration yaml. Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
feat/bump-mockery
branch
from
82be4b7 to
6992f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packages feature in mockery is the new way for managing mocks, and will be the only way to generate mocks in v3. see
https://vektra.github.io/mockery/v2.43/migrating_to_packages/.
Significant improvement in performance after using the packaging feature.
Before:
time go generate ./... go generate ./... 25.96s user 40.71s system 177% cpu 37.586 totalAfter:
$ time mockery mockery 0.94s user 0.90s system 154% cpu 1.195 totalThank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #20125
Please indicate you've done the following: