Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable the scan related button when installation without scanner or scanner deactived #20652

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 24, 2024

disable the scan related button when installation without scanner or scanner deactived.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20643

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added the release-note/update Update or Fix label Jun 24, 2024
@chlins chlins requested a review from a team as a code owner June 24, 2024 07:19
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (b7b8847) to head (8e3d0b5).
Report is 230 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20652      +/-   ##
==========================================
- Coverage   67.56%   66.25%   -1.31%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113477    +4296     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75185    +1417     
- Misses      31449    34186    +2737     
- Partials     3964     4106     +142     
Flag Coverage Δ
unittests 66.25% <ø> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 571 files with indirect coverage changes

@chlins chlins force-pushed the fix/unify-scan-ui-btn branch from 3700bed to c1fd287 Compare June 24, 2024 08:40
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang enabled auto-merge (squash) June 25, 2024 05:19
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 35d1032 into goharbor:main Jun 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scan vulnerability button should not disappear when deactivate a scanner
5 participants