Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Response an error message when there is incomplete sbom generate job #20527

Merged
merged 1 commit into from
May 31, 2024

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 31, 2024 07:35
@stonezdj stonezdj added the release-note/update Update or Fix label May 31, 2024
@stonezdj stonezdj changed the title Response an error message when there is uncomplete sbom generate job [cherry-pick] Response an error message when there is uncomplete sbom generate job May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@9944059). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20527   +/-   ##
=================================================
  Coverage                  ?   46.24%           
=================================================
  Files                     ?      247           
  Lines                     ?    13775           
  Branches                  ?     2844           
=================================================
  Hits                      ?     6370           
  Misses                    ?     7076           
  Partials                  ?      329           
Flag Coverage Δ
unittests 46.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@stonezdj stonezdj force-pushed the 2.11_sbom_job_reentry branch from 4fcb925 to e43cb48 Compare May 31, 2024 07:44
@stonezdj stonezdj force-pushed the 2.11_sbom_job_reentry branch from e43cb48 to 2732c72 Compare May 31, 2024 07:51
@stonezdj stonezdj changed the title [cherry-pick] Response an error message when there is uncomplete sbom generate job [cherry-pick] Response an error message when there is incomplete sbom generate job May 31, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 33de1ad into goharbor:release-2.11.0 May 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants