Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 20518 #20521

Merged
merged 2 commits into from
May 30, 2024
Merged

fix 20518 #20521

merged 2 commits into from
May 30, 2024

Conversation

wy65701436
Copy link
Contributor

fixes #20518
Since there is no report for the replicated artifact, update to use the artifact id to remove accessories.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 66.24%. Comparing base (b7b8847) to head (0dd6d69).
Report is 205 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20521      +/-   ##
==========================================
- Coverage   67.56%   66.24%   -1.32%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113483    +4302     
  Branches     2719     2844     +125     
==========================================
+ Hits        73768    75180    +1412     
- Misses      31449    34195    +2746     
- Partials     3964     4108     +144     
Flag Coverage Δ
unittests 66.24% <36.36%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/sbom.go 52.25% <36.36%> (ø)

... and 571 files with indirect coverage changes

fixes goharbor#20518
Since there is no report for the replicated artifact, update to use the artifact id to remove accessories.

Signed-off-by: wang yan <[email protected]>
@zyyw zyyw merged commit d847590 into goharbor:main May 30, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBOM replicated to destination Harbor is not deleted for the first time when triggering SBOM manual generation
6 participants