Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbom_report table to store sbom related information #20473

Merged
merged 1 commit into from
May 24, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented May 22, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20445

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 22, 2024 14:58
@stonezdj stonezdj force-pushed the 24may20_multi_repo_sbom branch from bae9176 to a74ff38 Compare May 23, 2024 02:08
@stonezdj stonezdj assigned wy65701436 and zyyw and unassigned Vad1mo and AllForNothing May 23, 2024
@stonezdj stonezdj requested review from wy65701436, zyyw and MinerYang May 23, 2024 02:15
@stonezdj stonezdj force-pushed the 24may20_multi_repo_sbom branch from a74ff38 to 88b43e3 Compare May 23, 2024 02:19
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (b7b8847) to head (8bd2b1c).
Report is 199 commits behind head on main.

Current head 8bd2b1c differs from pull request most recent head 7519982

Please upload reports for the commit 7519982 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20473       +/-   ##
===========================================
- Coverage   67.56%   46.35%   -21.22%     
===========================================
  Files         991      247      -744     
  Lines      109181    13770    -95411     
  Branches     2719     2842      +123     
===========================================
- Hits        73768     6383    -67385     
+ Misses      31449     7059    -24390     
+ Partials     3964      328     -3636     
Flag Coverage Δ
unittests 46.35% <ø> (-21.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24may20_multi_repo_sbom branch from 88b43e3 to ecb80ef Compare May 23, 2024 05:39
src/pkg/scan/sbom/sbom.go Outdated Show resolved Hide resolved
src/pkg/scan/sbom/dao/dao.go Outdated Show resolved Hide resolved
src/pkg/scan/sbom/dao/dao.go Outdated Show resolved Hide resolved
src/pkg/scan/sbom/manager.go Outdated Show resolved Hide resolved
src/pkg/scan/sbom/manager.go Outdated Show resolved Hide resolved
src/pkg/scan/sbom/manager.go Outdated Show resolved Hide resolved
@stonezdj stonezdj force-pushed the 24may20_multi_repo_sbom branch from 59071dd to 82aad6b Compare May 23, 2024 09:25
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.24%. Comparing base (b7b8847) to head (fccc50a).
Report is 199 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20473       +/-   ##
===========================================
- Coverage   67.56%   46.24%   -21.32%     
===========================================
  Files         991      247      -744     
  Lines      109181    13770    -95411     
  Branches     2719     2842      +123     
===========================================
- Hits        73768     6368    -67400     
+ Misses      31449     7074    -24375     
+ Partials     3964      328     -3636     
Flag Coverage Δ
unittests 46.24% <ø> (-21.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24may20_multi_repo_sbom branch from b55ae66 to 6beda61 Compare May 24, 2024 06:25
  fixes goharbor#20445
  Refactor scan/base_controller.go
  Move MakeReportPlaceholder, GetReportPlaceholder, GetSummary to vul and sbom scanHandler

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 24may20_multi_repo_sbom branch from 6beda61 to fccc50a Compare May 24, 2024 08:12
@stonezdj stonezdj enabled auto-merge (squash) May 24, 2024 08:13
@stonezdj stonezdj merged commit 1f0c828 into goharbor:main May 24, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sbom_overview still get sbom_digest when this sbom artifact do not exist in this repository
7 participants