Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19928 #20409

Merged
merged 7 commits into from
May 15, 2024
Merged

fix issue 19928 #20409

merged 7 commits into from
May 15, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 9, 2024

it needs to consider the user who is in any group that has been granted with the project admin role.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19928

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner May 9, 2024 07:49
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.36%. Comparing base (b7b8847) to head (60044f1).
Report is 182 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20409      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.20%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113132    +3951     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75084    +1316     
- Misses      31449    33984    +2535     
- Partials     3964     4064     +100     
Flag Coverage Δ
unittests 66.36% <60.00%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/rbac/project/rbac_role.go 70.00% <ø> (ø)
src/controller/member/controller.go 21.15% <100.00%> (ø)
src/pkg/cached/project/redis/manager.go 55.69% <0.00%> (ø)
src/pkg/project/manager.go 5.26% <0.00%> (ø)
src/pkg/project/dao/dao.go 70.83% <86.36%> (+7.05%) ⬆️
src/server/v2.0/handler/permissions.go 0.00% <0.00%> (ø)

... and 566 files with indirect coverage changes

@wy65701436 wy65701436 force-pushed the fix-19928 branch 2 times, most recently from e6400b3 to 40f13ab Compare May 9, 2024 08:27
@wy65701436 wy65701436 added the release-note/update Update or Fix label May 9, 2024
src/pkg/project/dao/dao.go Outdated Show resolved Hide resolved
it needs to consider the user who is in any group that has been granted with the project admin role.

Signed-off-by: wang yan <[email protected]>
Signed-off-by: wang yan <[email protected]>
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: wang yan <[email protected]>
Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 merged commit 2977fec into goharbor:main May 15, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants