Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20269 #20274

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix issue 20269 #20274

merged 2 commits into from
Apr 16, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Apr 15, 2024

By default, use the nvd score as the primary score, and if it is unavailable, fallback to the redhat score. fix #20269

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.40%. Comparing base (b7b8847) to head (a9df45b).
Report is 137 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20274      +/-   ##
==========================================
- Coverage   67.56%   66.40%   -1.17%     
==========================================
  Files         991     1039      +48     
  Lines      109181   112542    +3361     
  Branches     2719     2781      +62     
==========================================
+ Hits        73768    74730     +962     
- Misses      31449    33787    +2338     
- Partials     3964     4025      +61     
Flag Coverage Δ
unittests 66.40% <100.00%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/postprocessors/report_converters.go 61.45% <100.00%> (+0.98%) ⬆️

... and 558 files with indirect coverage changes

By default, use the nvd score as the primary score, and if it is unavailable, fallback to the redhat score.
fix goharbor#20269

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 merged commit 550bf1d into goharbor:main Apr 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse the cvss3 score in the securityhub
5 participants