Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update referrer manifest descriptor size #20207

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Apr 2, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#20187

curl -k -u 'admin:pwd' https://xx.xxx.xxx.xx/v2/library/hello-world/referrers/sha256:d37ada95d47ad12224c205a938129df7a3e52345828b4fa27b03a98825d1e2e7 | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   300  100   300    0     0  26073      0 --:--:-- --:--:-- --:--:-- 27272
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:8a12406f6f62e297a93400610fa6a136c7fcf6a0956219bc929676014d2f2fc3",
      "size": 1620,
      "artifactType": "application/vnd.oci.image.config.v1+json"
    }
  ]
}
/data/registry/docker/registry/v2/blobs/sha256$ wc -c <  8a/8a12406f6f62e297a93400610fa6a136c7fcf6a0956219bc929676014d2f2fc3/data
1620

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.21%. Comparing base (b7b8847) to head (4889c28).
Report is 120 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20207       +/-   ##
===========================================
- Coverage   67.56%   46.21%   -21.36%     
===========================================
  Files         991      246      -745     
  Lines      109181    13565    -95616     
  Branches     2719     2781       +62     
===========================================
- Hits        73768     6269    -67499     
+ Misses      31449     6980    -24469     
+ Partials     3964      316     -3648     
Flag Coverage Δ
unittests 46.21% <ø> (-21.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1237 files with indirect coverage changes

@MinerYang MinerYang changed the title upddate referrer manifest descriptor size update referrer manifest descriptor size Apr 2, 2024
@MinerYang MinerYang force-pushed the fix_refererr_descriptor_size branch from d6ac496 to af5e2bb Compare April 2, 2024 02:42
@MinerYang MinerYang force-pushed the fix_refererr_descriptor_size branch 2 times, most recently from 606138f to 4423e11 Compare April 2, 2024 06:43
@MinerYang MinerYang force-pushed the fix_refererr_descriptor_size branch 3 times, most recently from d111a1f to 8a89818 Compare April 8, 2024 06:26
@MinerYang MinerYang force-pushed the fix_refererr_descriptor_size branch from 8a89818 to 0cb99c0 Compare April 8, 2024 07:12
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang force-pushed the fix_refererr_descriptor_size branch 2 times, most recently from a7dd8f2 to c1f1096 Compare April 9, 2024 05:31
cache manifest when first time pull if cacheEnabled

Signed-off-by: yminer <[email protected]>
@MinerYang MinerYang force-pushed the fix_refererr_descriptor_size branch from c1f1096 to ee09c60 Compare April 9, 2024 07:36
@MinerYang MinerYang enabled auto-merge (squash) April 9, 2024 07:39
@MinerYang MinerYang merged commit 03d9575 into goharbor:main Apr 9, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants