Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] panic due to mark retention task error #20170

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20129

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.92%. Comparing base (ccfc3f8) to head (92c97cf).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.9.0   #20170       +/-   ##
==================================================
- Coverage          67.42%   44.92%   -22.51%     
==================================================
  Files                993      244      -749     
  Lines             108982    13417    -95565     
  Branches            2752     2752               
==================================================
- Hits               73486     6027    -67459     
+ Misses             31540     7085    -24455     
+ Partials            3956      305     -3651     
Flag Coverage Δ
unittests 44.92% <ø> (-22.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 751 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) March 26, 2024 05:39
@stonezdj stonezdj merged commit 8d9f7f5 into goharbor:release-2.9.0 Mar 26, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants