Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic due to mark retention task error #20161

Merged
merged 1 commit into from
Mar 26, 2024
Merged

panic due to mark retention task error #20161

merged 1 commit into from
Mar 26, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20129

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner March 25, 2024 07:39
@stonezdj stonezdj force-pushed the 24mar25_fix_error_with_exec branch from 2e1292c to 7f2adc0 Compare March 25, 2024 07:40
wy65701436
wy65701436 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chlins
chlins approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24mar25_fix_error_with_exec branch from 3428f06 to 74d9d2a Compare March 25, 2024 09:25
@stonezdj stonezdj added the release-note/update Update or Fix label Mar 25, 2024
@stonezdj stonezdj force-pushed the 24mar25_fix_error_with_exec branch 2 times, most recently from bad80b4 to a430b9b Compare March 25, 2024 13:04
@stonezdj stonezdj enabled auto-merge (squash) March 26, 2024 02:09
@stonezdj stonezdj force-pushed the 24mar25_fix_error_with_exec branch 3 times, most recently from 7d9906b to db8812b Compare March 26, 2024 03:25
@stonezdj stonezdj force-pushed the 24mar25_fix_error_with_exec branch from db8812b to 7937898 Compare March 26, 2024 04:15
@stonezdj stonezdj merged commit 80a9c68 into goharbor:main Mar 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@wy65701436 wy65701436

@zyyw zyyw

@OrlinVasilev OrlinVasilev

@chlins chlins

@MinerYang MinerYang

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag retention rules for multiple repos with slashes crashes the backend
6 participants
@stonezdj @wy65701436 @chlins @zyyw @OrlinVasilev @MinerYang