Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit url to local path #20025

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Feb 23, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner February 23, 2024 08:39
@stonezdj stonezdj force-pushed the 24feb23_limit_local_path branch from 0d74589 to 5b105fc Compare February 23, 2024 08:47
@Vad1mo Vad1mo enabled auto-merge (squash) February 23, 2024 08:50
@stonezdj stonezdj force-pushed the 24feb23_limit_local_path branch from 5b105fc to e42a926 Compare February 23, 2024 08:51
@stonezdj stonezdj added the release-note/update Update or Fix label Feb 23, 2024
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24feb23_limit_local_path branch 2 times, most recently from f168297 to b7f33f7 Compare February 23, 2024 10:13
Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 24feb23_limit_local_path branch from b7f33f7 to 1f5d08e Compare February 24, 2024 00:58
@Vad1mo Vad1mo merged commit 5b832c1 into goharbor:main Feb 24, 2024
10 checks passed
@pborn-ionos
Copy link

This seems to break Harbor for us. When you're on /account/sign-in with OIDC, the login button for OIDC points to /c/oidc/login?redirect_url= and an empty redirect_url errors out with

{
  "errors": [
    {
      "code": "BAD_REQUEST",
      "message": "cannot redirect to other site"
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants