Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant file package-lock.json under src folder #20007

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Remove redundant file package-lock.json under src folder #20007

merged 2 commits into from
Feb 23, 2024

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Feb 21, 2024 •
edited
Loading

Remove redundant file package-lock.json under src folder. This file was introduced by #19733.

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner February 21, 2024 10:34
@AllForNothing AllForNothing added the release-note/update Update or Fix label Feb 21, 2024
chlins
chlins approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

MinerYang
MinerYang approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit fa6b138 into goharbor:main Feb 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerYang MinerYang MinerYang approved these changes

@chlins chlins chlins approved these changes

Assignees

@Vad1mo Vad1mo

@OrlinVasilev OrlinVasilev

@MinerYang MinerYang

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllForNothing @chlins @MinerYang @Vad1mo @OrlinVasilev