Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]add v6 port for nginx ad portal config #19893

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Jan 23, 2024
@MinerYang MinerYang requested a review from a team as a code owner January 23, 2024 07:39
@MinerYang MinerYang assigned wy65701436 and unassigned Vad1mo and OrlinVasilev Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9731fdd) 67.42% compared to head (dfeabd5) 67.43%.
Report is 2 commits behind head on release-2.9.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.9.0   #19893   +/-   ##
==============================================
  Coverage          67.42%   67.43%           
==============================================
  Files                993      993           
  Lines             108938   108938           
  Branches            2752     2752           
==============================================
+ Hits               73448    73458   +10     
+ Misses             31534    31525    -9     
+ Partials            3956     3955    -1     
Flag Coverage Δ
unittests 67.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 8bd8c6d into goharbor:release-2.9.0 Jan 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants