Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh base images on release-2.9.0 #19851

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db06a72) 67.42% compared to head (ae7aefa) 67.42%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.9.0   #19851   +/-   ##
==============================================
  Coverage          67.42%   67.42%           
==============================================
  Files                993      993           
  Lines             108937   108937           
  Branches            2752     2752           
==============================================
+ Hits               73448    73451    +3     
+ Misses             31536    31533    -3     
  Partials            3953     3953           
Flag Coverage Δ
unittests 67.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 5bda4b7 into goharbor:release-2.9.0 Jan 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants