-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update isValidDuration function #19843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangJiao0817
added
area/robot-account
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
labels
Jan 15, 2024
YangJiao0817
force-pushed
the
fix-robot-duration
branch
from
January 15, 2024 06:11
f81d0e5
to
2fc9042
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19843 +/- ##
===========================================
- Coverage 70.64% 45.30% -25.35%
===========================================
Files 747 244 -503
Lines 95839 13332 -82507
Branches 0 2720 +2720
===========================================
- Hits 67709 6040 -61669
+ Misses 24465 6992 -17473
+ Partials 3665 300 -3365
Flags with carried forward coverage won't be shown. Click here to find out more. |
wy65701436
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
YangJiao0817
force-pushed
the
fix-robot-duration
branch
2 times, most recently
from
January 15, 2024 06:50
43da246
to
b933664
Compare
YangJiao0817
added
release-note/update
Update or Fix
and removed
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
labels
Jan 15, 2024
stonezdj
approved these changes
Jan 17, 2024
Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817
force-pushed
the
fix-robot-duration
branch
from
January 17, 2024 08:06
b933664
to
c67c0ce
Compare
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Yang Jiao <[email protected]> Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: