Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Cache image list with digest key #19837

Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jan 12, 2024

fixes #19429

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b622d4a) 67.42% compared to head (394fe30) 67.42%.
Report is 2 commits behind head on release-2.9.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19837      +/-   ##
=================================================
- Coverage          67.42%   67.42%   -0.01%     
=================================================
  Files                993      993              
  Lines             108932   108938       +6     
  Branches            2752     2752              
=================================================
+ Hits               73444    73448       +4     
  Misses             31534    31534              
- Partials            3954     3956       +2     
Flag Coverage Δ
unittests 67.42% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/proxy/controller.go 15.59% <50.00%> (-0.26%) ⬇️
src/controller/proxy/manifestcache.go 26.27% <0.00%> (-0.59%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 84d7f17 into goharbor:release-2.9.0 Jan 15, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants