Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quota sorting to the project quotas list #19576

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 14, 2023

  1. For Projects can not be sorted by consumed quota in "Project Quotas" #16517

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner November 14, 2023 08:23
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #19576 (676110c) into main (6a6e295) will decrease coverage by 22.17%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19576       +/-   ##
===========================================
- Coverage   67.53%   45.36%   -22.17%     
===========================================
  Files         990      244      -746     
  Lines      109057    13320    -95737     
  Branches     2720     2720               
===========================================
- Hits        73653     6043    -67610     
+ Misses      31438     6975    -24463     
+ Partials     3966      302     -3664     
Flag Coverage Δ
unittests 45.36% <ø> (-22.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-quotas/project-quotas/project-quotas.component.ts 48.14% <ø> (ø)

... and 749 files with indirect coverage changes

@AllForNothing AllForNothing merged commit 7718134 into goharbor:main Nov 15, 2023
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. For goharbor#16517

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants