Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heading to contributing docs #19412

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add heading to contributing docs #19412

merged 1 commit into from
Oct 6, 2023

Conversation

mterwill
Copy link
Contributor

@mterwill mterwill commented Oct 3, 2023 •
edited
Loading

Comprehensive Summary of your change

I was searching for documentation on how to build the project and skimmed this but missed the link to the website since it's under the 'fork repository' heading.

Issue being fixed

N/A

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@mterwill mterwill requested a review from a team as a code owner October 3, 2023 13:55
@mterwill
Add heading to contributing docs
4418335 
I was searching for documentation on how to build the project and
skimmed this but missed the link to the website since it's under the
'fork repository' heading.

Signed-off-by: Matthew Terwilliger <[email protected]>
@mterwill mterwill force-pushed the update-contributing branch from 4d58cff to 4418335 Compare October 3, 2023 13:56
@Vad1mo Vad1mo enabled auto-merge (squash) October 4, 2023 12:51
@chlins chlins added area/doc Issues to track documentation tasks release-note/docs Docs changes(made and needed) labels Oct 6, 2023
chlins
chlins approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo Vad1mo merged commit 950f19e into goharbor:main Oct 6, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@Vad1mo Vad1mo Vad1mo approved these changes

Assignees

@stonezdj stonezdj

@zyyw zyyw

@OrlinVasilev OrlinVasilev

Labels
area/doc Issues to track documentation tasks release-note/docs Docs changes(made and needed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mterwill @Vad1mo @chlins @stonezdj @zyyw @OrlinVasilev