Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add security hub API test case #19377

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Sep 20, 2023

Fix #19269

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #19377 (e365e54) into release-2.9.0 (0b9645d) will increase coverage by 0.02%.
Report is 1 commits behind head on release-2.9.0.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19377      +/-   ##
=================================================
+ Coverage          67.39%   67.41%   +0.02%     
=================================================
  Files                993      993              
  Lines             108921   108921              
  Branches            2752     2752              
=================================================
+ Hits               73403    73426      +23     
+ Misses             31573    31546      -27     
- Partials            3945     3949       +4     
Flag Coverage Δ
unittests 67.41% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) September 20, 2023 10:32
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 3c62b75 into goharbor:release-2.9.0 Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants