Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tooltip for the page title of security hub #19231

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Add a tooltip for the page title of security hub #19231

merged 1 commit into from
Aug 24, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 22, 2023 •
edited
Loading

image
  1. This tooltip explains the artifacts total count

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner August 22, 2023 08:08
@AllForNothing AllForNothing added the release-note/update Update or Fix label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #19231 (2ca8483) into main (23fd87a) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19231      +/-   ##
==========================================
+ Coverage   67.33%   67.41%   +0.07%     
==========================================
  Files         993      993              
  Lines      108896   108896              
  Branches     2751     2751              
==========================================
+ Hits        73329    73412      +83     
+ Misses      31631    31541      -90     
- Partials     3936     3943       +7
Flag Coverage Δ
unittests 67.41% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

@AllForNothing AllForNothing mentioned this pull request Aug 22, 2023
Merged
5 tasks
@AllForNothing AllForNothing requested a review from Vad1mo August 22, 2023 08:30
@AllForNothing
Copy link
Contributor Author

@Vad1mo We are trying to add a tooltip for the artifact total count:
image
total count = artifacts + accessories + child artifact of index + child artifact of CNAB
Any suggestions for the English text?

Vad1mo
Vad1mo previously requested changes Aug 23, 2023
View reviewed changes
src/portal/src/i18n/lang/fr-fr-lang.json Outdated
@@ -1859,6 +1859,7 @@
"REPO_NAME": "Repository Name",
"TOOLTIP": "All filters except CVSS3 only support exact matches",
"NO_VUL": "We could not find any vulnerability",
"INVALID_VALUE": "Invalid range"
"INVALID_VALUE": "Invalid range",
"PAGE_TITLE_TOOLTIP": "The total artifact count includes artifact accessories, child artifacts of the image index, and child artifacts of CNAB artifacts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total artifact count also includes artifact accessories, OCI Image Index child artifacts, and CNAB child artifacts

src/portal/src/i18n/lang/en-us-lang.json Outdated
@@ -1893,6 +1893,7 @@
"REPO_NAME": "Repository Name",
"TOOLTIP": "All filters except CVSS3 only support exact matches",
"NO_VUL": "We could not find any vulnerability",
"INVALID_VALUE": "Invalid range"
"INVALID_VALUE": "Invalid range",
"PAGE_TITLE_TOOLTIP": "The total artifact count includes artifact accessories, child artifacts of the image index, and child artifacts of CNAB artifacts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total artifact count also includes OCI artifact accessories, OCI Image Index child artifacts, and CNAB child artifacts

@Vad1mo
Copy link
Member

Vad1mo commented Aug 23, 2023

Also I would set the total text to:

Total count = OCI artifacts + OCI artifact accessories + Image index child artifacts + CNAB + CNAB child artifacts.

@AllForNothing
Add a tooltip for the page title of security hub
2ca8483 
1. This tooltip explains the artifacts total count

Signed-off-by: AllForNothing <[email protected]>
wy65701436
wy65701436 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit dd90313 into goharbor:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

@Vad1mo Vad1mo Vad1mo left review comments

Assignees

@AllForNothing AllForNothing

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AllForNothing @Vad1mo @stonezdj @wy65701436 @OrlinVasilev @MinerYang