Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine total artifact and scanned artifact #19228

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Aug 22, 2023

fixes #19215

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner August 22, 2023 03:45
@stonezdj stonezdj added the release-note/update Update or Fix label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #19228 (4e6bd5b) into main (444404f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19228      +/-   ##
==========================================
- Coverage   67.41%   67.40%   -0.01%     
==========================================
  Files         993      993              
  Lines      108896   108896              
  Branches     2751     2751              
==========================================
- Hits        73413    73403      -10     
- Misses      31537    31546       +9     
- Partials     3946     3947       +1     
Flag Coverage Δ
unittests 67.40% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/securityhub/dao/security.go 59.60% <100.00%> (ø)

... and 7 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23aug22_refine_scanned_artifact branch from 20d794e to 52fa40e Compare August 22, 2023 03:52
  Artifact include all accessory, child artifact
  fixes goharbor#19215

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 23aug22_refine_scanned_artifact branch from 52fa40e to 4e6bd5b Compare August 22, 2023 05:02
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@stonezdj stonezdj merged commit 298ecbb into goharbor:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Security Hub statistics of CNAB Bundle are incorrect
6 participants