Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: privileges member successfully typo #19091

Merged
merged 2 commits into from
Aug 7, 2023
Merged

fix: privileges member successfully typo #19091

merged 2 commits into from
Aug 7, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Aug 3, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

fix: privileges member successfully typo

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@testwill testwill requested a review from a team as a code owner August 3, 2023 03:01
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #19091 (d0a8cfe) into main (b8f2ef9) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19091      +/-   ##
==========================================
+ Coverage   70.58%   70.61%   +0.03%     
==========================================
  Files         748      748              
  Lines       95379    95379              
==========================================
+ Hits        67320    67351      +31     
+ Misses      24420    24397      -23     
+ Partials     3639     3631       -8     
Flag Coverage Δ
unittests 70.61% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@chlins
Copy link
Member

chlins commented Aug 4, 2023

@testwill Thanks for your contribution! Please rewrite your commit message and PR description to be more clear.

@testwill testwill changed the title fix: typo fix: privileges member successfully typo Aug 4, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw self-requested a review August 7, 2023 08:35
@zyyw zyyw added the release-note/update Update or Fix label Aug 7, 2023
@zyyw zyyw merged commit 345b5e5 into goharbor:main Aug 7, 2023
@testwill testwill deleted the typo branch August 7, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants