Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplicated artifact deletion handler #18959

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Jul 20, 2023

Remove the duplicated artifact deletion event handler and enhance the internal artifact onDelete method.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #18959 (6e9d0d2) into main (26f6197) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18959      +/-   ##
==========================================
- Coverage   67.42%   67.41%   -0.01%     
==========================================
  Files         993      992       -1     
  Lines      108772   108751      -21     
  Branches     2747     2747              
==========================================
- Hits        73341    73319      -22     
+ Misses      31502    31501       -1     
- Partials     3929     3931       +2     
Flag Coverage Δ
unittests 67.41% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/internal/artifact.go 75.70% <62.50%> (+0.70%) ⬆️

... and 10 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the refactor/remove-scan-del-webhook branch from 96bba2a to 8941103 Compare July 21, 2023 12:35
Remove the duplicated artifact deletion event handler and enhance the
internal artifact onDelete method.

Signed-off-by: chlins <[email protected]>
@chlins chlins force-pushed the refactor/remove-scan-del-webhook branch from 8941103 to 6e9d0d2 Compare July 24, 2023 02:56
@chlins chlins merged commit 94c7600 into goharbor:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants