Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning message when current user is freeze #18937

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jul 16, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner July 16, 2023 07:37
@stonezdj stonezdj added the release-note/update Update or Fix label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #18937 (ed6f0ec) into main (d745ad9) will decrease coverage by 3.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18937      +/-   ##
==========================================
- Coverage   70.57%   67.41%   -3.16%     
==========================================
  Files         750      986     +236     
  Lines       94817   107995   +13178     
  Branches        0     2698    +2698     
==========================================
+ Hits        66914    72805    +5891     
- Misses      24297    31292    +6995     
- Partials     3606     3898     +292     
Flag Coverage Δ
unittests 67.41% <0.00%> (-3.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/auth/authenticator.go 48.81% <0.00%> (ø)

... and 237 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 82ee529 into goharbor:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants