Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add replication by chunk testcase #18903

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jul 7, 2023

Fix #17951

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #18903 (101e7b7) into release-2.8.0 (f8282a5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #18903      +/-   ##
=================================================
- Coverage          67.39%   67.38%   -0.01%     
=================================================
  Files                984      984              
  Lines             107025   107025              
  Branches            2670     2670              
=================================================
- Hits               72125    72116       -9     
- Misses             31017    31031      +14     
+ Partials            3883     3878       -5     
Flag Coverage Δ
unittests 67.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 requested a review from zyyw July 7, 2023 07:14
@YangJiao0817 YangJiao0817 merged commit 4c335f7 into goharbor:release-2.8.0 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants