Remove wrong format for boolean value in api definition #18783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type: boolean cannot be used with a format of int32 Signed-off-by: sll552 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #18783 +/- ##
==========================================
+ Coverage 67.34% 67.37% +0.03%
==========================================
Files 980 980
Lines 106831 106829 -2
Branches 2665 2665
==========================================
+ Hits 71949 71980 +31
+ Misses 31016 30979 -37
- Partials 3866 3870 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@sll552 congrats on merging your first PR here :) welcome to the club :) |
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
type: boolean cannot be used with a format of int32 Signed-off-by: sll552 <[email protected]> Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
type: boolean cannot be used with a format of int32 Signed-off-by: sll552 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
type: boolean cannot be used with a format of int32
This for example hinders parsing of the api definition by other tools such as https://github.com/OpenAPITools/openapi-generator
Issue being fixed
Please indicate you've done the following: