-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve repo_read_only header on the UI #18729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixes goharbor#18694 2. Now non-system-admin users can also see the repo_read_only header Signed-off-by: AllForNothing <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #18729 +/- ##
==========================================
- Coverage 67.37% 67.37% -0.01%
==========================================
Files 980 980
Lines 106749 106739 -10
Branches 2668 2665 -3
==========================================
- Hits 71927 71918 -9
- Misses 30958 30960 +2
+ Partials 3864 3861 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
YangJiao0817
approved these changes
May 24, 2023
wy65701436
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1. Fixes goharbor#18694 2. Now non-system-admin users can also see the repo_read_only header Signed-off-by: AllForNothing <[email protected]> Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1. Fixes goharbor#18694 2. Now non-system-admin users can also see the repo_read_only header Signed-off-by: AllForNothing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read_only
header on Harbor UI should be visible for every user #18694Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: