-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove chart-museum related to logic #18722
remove chart-museum related to logic #18722
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18722 +/- ##
==========================================
+ Coverage 44.80% 44.87% +0.06%
==========================================
Files 244 244
Lines 13416 13416
Branches 2752 2752
==========================================
+ Hits 6011 6020 +9
+ Misses 7100 7090 -10
- Partials 305 306 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
f4690cb
to
49d1a2f
Compare
Signed-off-by: lengrongfu <[email protected]>
49d1a2f
to
47e15a2
Compare
@MinerYang @chlins Hi, PTAL. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
/reopen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for contributing to Harbor!
Comprehensive Summary of your change
The logic to remove harbor_resource_label will be removed after chart-museum is removed.
Issue being fixed
Fixes #(issue) #17958
/label release-note/update
Please indicate you've done the following: