Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove chart-museum related to logic #18722

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

lengrongfu
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

The logic to remove harbor_resource_label will be removed after chart-museum is removed.

Issue being fixed

Fixes #(issue) #17958

/label release-note/update

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@lengrongfu lengrongfu requested a review from a team as a code owner May 23, 2023 15:30
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #18722 (2d67387) into main (7f19163) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18722      +/-   ##
==========================================
+ Coverage   44.80%   44.87%   +0.06%     
==========================================
  Files         244      244              
  Lines       13416    13416              
  Branches     2752     2752              
==========================================
+ Hits         6011     6020       +9     
+ Misses       7100     7090      -10     
- Partials      305      306       +1     
Flag Coverage Δ
unittests 44.87% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@lengrongfu lengrongfu force-pushed the feat/remove-chartmuseum-logic branch 2 times, most recently from f4690cb to 49d1a2f Compare May 26, 2023 07:11
@lengrongfu lengrongfu force-pushed the feat/remove-chartmuseum-logic branch from 49d1a2f to 47e15a2 Compare May 29, 2023 03:40
@lengrongfu
Copy link
Contributor Author

@MinerYang @chlins Hi, PTAL.

@AllForNothing AllForNothing assigned wy65701436 and unassigned zyyw and MinerYang May 29, 2023
@github-actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Jul 28, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Aug 28, 2023
@lengrongfu
Copy link
Contributor Author

/reopen

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins added the release-note/update Update or Fix label Sep 11, 2023
@wy65701436 wy65701436 removed the Stale label Sep 11, 2023
@chlins chlins merged commit d55823d into goharbor:main Sep 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants