-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TLSv1.3 in nginx configurations #18659
Conversation
Hi @malmor , |
Signed-off-by: malmor <[email protected]>
44f9b2b
to
4feddcb
Compare
Hey @MinerYang, |
Codecov Report
@@ Coverage Diff @@
## main #18659 +/- ##
===========================================
+ Coverage 44.78% 67.39% +22.60%
===========================================
Files 235 980 +745
Lines 13067 106739 +93672
Branches 2665 2665
===========================================
+ Hits 5852 71935 +66083
- Misses 6920 30941 +24021
- Partials 295 3863 +3568
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@malmor thank you for contributing :) congrats on your first PR here :) |
Signed-off-by: malmor <[email protected]> Co-authored-by: MinerYang <[email protected]> Signed-off-by: Wilfred Almeida <[email protected]>
Signed-off-by: malmor <[email protected]> Co-authored-by: MinerYang <[email protected]>
For those who are looking to get TLSv1.3 before the release 2.9.0 comes out, you can add to line echo "Adding support for TLSv1.3"
sed -i $config_dir/nginx/nginx.conf -e 's/ssl_protocols TLSv1.2/ssl_protocols TLSv1.2 TLSv1.3/g' Because the |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
This PR enables
TLSv1.3
by default in the nginx configuration. This way the configuration follows the linked recommendations and the nginx default configuration.Issue being fixed
Fixes #18358
Please indicate you've done the following: