Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy swagger.json to the dist folder #18646

Merged
merged 1 commit into from
May 9, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented May 8, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner May 8, 2023 04:14
@AllForNothing AllForNothing added the release-note/infra Infra related changes e.g. release, test, ship etc... label May 8, 2023
@AllForNothing AllForNothing requested review from zyyw and YangJiao0817 May 8, 2023 04:15
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #18646 (72ce4e0) into main (0e3e70b) will decrease coverage by 22.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18646       +/-   ##
===========================================
- Coverage   67.37%   44.74%   -22.63%     
===========================================
  Files         984      235      -749     
  Lines      107029    13089    -93940     
  Branches     2670     2670               
===========================================
- Hits        72112     5857    -66255     
+ Misses      31035     6939    -24096     
+ Partials     3882      293     -3589     
Flag Coverage Δ
unittests 44.74% <ø> (-22.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 752 files with indirect coverage changes

@AllForNothing AllForNothing merged commit 2fec790 into goharbor:main May 9, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants