Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notary test cases #18620

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Remove notary test cases #18620

merged 1 commit into from
Apr 28, 2023

Conversation

YangJiao0817
Copy link
Member

Fix #17955

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 requested a review from a team as a code owner April 27, 2023 09:45
@YangJiao0817 YangJiao0817 marked this pull request as draft April 27, 2023 09:45
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Merging #18620 (4778c05) into main (1bbe8c5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18620      +/-   ##
==========================================
- Coverage   67.39%   67.37%   -0.03%     
==========================================
  Files         984      984              
  Lines      107010   107010              
  Branches     2670     2670              
==========================================
- Hits        72119    72097      -22     
- Misses      31012    31035      +23     
+ Partials     3879     3878       -1
Flag Coverage Δ
unittests 67.37% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@YangJiao0817 YangJiao0817 force-pushed the remove-notary-testcase branch from a3a2665 to 4778c05 Compare April 28, 2023 02:07
@YangJiao0817 YangJiao0817 marked this pull request as ready for review April 28, 2023 04:59
wy65701436
wy65701436 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit c09e539 into goharbor:main Apr 28, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
@YangJiao0817 @WilfredAlmeida
Remove notary test cases (goharbor#18620)
c6c7440 
Fix goharbor#17955

Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllForNothing AllForNothing AllForNothing approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@wy65701436 wy65701436

@AllForNothing AllForNothing

@YangJiao0817 YangJiao0817

Labels
area/test automation/nightly-testing release-note/deprecation Harbor Deprecation MUST need to be in release notes target/2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Notary testcase
7 participants
@YangJiao0817 @wy65701436 @AllForNothing @Vad1mo @zyyw @chlins @MinerYang