Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize text modification of quota tooltip to all the i18n files #18518

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Apr 12, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner April 12, 2023 04:36
@AllForNothing AllForNothing added release-note/enhancement Label to mark PR to be added under release notes as enhancement release-note/update Update or Fix and removed release-note/enhancement Label to mark PR to be added under release notes as enhancement labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #18518 (e46b6e4) into main (b755c43) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e46b6e4 differs from pull request most recent head 1de115d. Consider uploading reports for the commit 1de115d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18518   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files         984      984           
  Lines      106987   106987           
  Branches     2670     2670           
=======================================
+ Hits        72099    72108    +9     
+ Misses      31002    31000    -2     
+ Partials     3886     3879    -7     
Flag Coverage Δ
unittests 67.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev OrlinVasilev merged commit b201f98 into goharbor:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants