Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stopScanAll on large number of artifacts #18360

Closed
wants to merge 2 commits into from

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Mar 16, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #18044

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw requested a review from a team as a code owner March 16, 2023 02:25
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #18360 (f9aeb0c) into main (5287c0e) will increase coverage by 0.01%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18360      +/-   ##
==========================================
+ Coverage   67.44%   67.46%   +0.01%     
==========================================
  Files         974      974              
  Lines      106410   106419       +9     
  Branches     2660     2660              
==========================================
+ Hits        71771    71795      +24     
+ Misses      30786    30767      -19     
- Partials     3853     3857       +4     
Flag Coverage Δ
unittests 67.46% <47.05%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/scan/callback.go 82.35% <0.00%> (ø)
src/controller/artifact/helper.go 75.00% <20.00%> (-25.00%) ⬇️
src/controller/scan/base_controller.go 60.61% <100.00%> (ø)
src/server/v2.0/handler/scan_all.go 87.74% <100.00%> (ø)

... and 3 files with indirect coverage changes

@zyyw zyyw force-pushed the fix-stopscanall branch from c2ba687 to 36821e9 Compare March 16, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop ScanAll not work in case of lots of artifacts.
4 participants