Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CHERRY-PICK) fix: resolve the codeql alerts #16127

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

chlins
Copy link
Member

@chlins chlins commented Dec 15, 2021

Signed-off-by: chlins [email protected]

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #16127 (2c6845d) into release-2.4.0 (c74305a) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.4.0   #16127      +/-   ##
=================================================
- Coverage          66.86%   66.85%   -0.01%     
=================================================
  Files                933      933              
  Lines              77728    77728              
  Branches            2287     2287              
=================================================
- Hits               51969    51967       -2     
- Misses             21752    21757       +5     
+ Partials            4007     4004       -3     
Flag Coverage Δ
unittests 66.85% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jobservice/logger/service.go 63.63% <77.77%> (ø)
...tegration/tag-retention/tag-retention.component.ts 29.95% <0.00%> (-2.21%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 23.07% <0.00%> (-1.29%) ⬇️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️
src/lib/cache/util.go 89.47% <0.00%> (+15.78%) ⬆️

@chlins chlins merged commit d406cb4 into goharbor:release-2.4.0 Dec 15, 2021
@yanji09 yanji09 added this to the Sprint 127 milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants