Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Enable db config cache explicitly #16016

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

stonezdj
Copy link
Contributor

previous config is not cached because it is initialized when cache is not ready

Signed-off-by: stonezdj [email protected]

  previous config is not cached because it is initialized when cache is not ready

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj changed the title Enable db config cache explicitly (cherry-pick) Enable db config cache explicitly Nov 17, 2021
@stonezdj stonezdj requested review from wy65701436 and heww November 17, 2021 06:18
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #16016 (162381d) into release-2.4.0 (b95b3fd) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.4.0   #16016      +/-   ##
=================================================
- Coverage          66.86%   66.82%   -0.04%     
=================================================
  Files                933      933              
  Lines              77712    77716       +4     
  Branches            2287     2287              
=================================================
- Hits               51962    51937      -25     
- Misses             21742    21774      +32     
+ Partials            4008     4005       -3     
Flag Coverage Δ
unittests 66.82% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/config/db/manager.go 46.15% <0.00%> (-20.52%) ⬇️
src/controller/event/handler/auditlog/auditlog.go 11.11% <0.00%> (-50.00%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/common/rbac/system/namespace.go 33.33% <0.00%> (-11.12%) ⬇️
src/controller/event/topic.go 1.80% <0.00%> (-9.01%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 46.82% <0.00%> (-3.97%) ⬇️
...g-retention-tasks/tag-retention-tasks.component.ts 58.33% <0.00%> (-2.78%) ⬇️
src/jobservice/runner/redis.go 67.82% <0.00%> (+5.21%) ⬆️

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 0395369 into goharbor:release-2.4.0 Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants