Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] upgrade golang to 1.16 #14872

Closed
wants to merge 1 commit into from
Closed

Conversation

wy65701436
Copy link
Contributor

Signed-off-by: wang yan [email protected]

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #14872 (2f7add4) into master (25c9b9d) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2f7add4 differs from pull request most recent head 3d9bfe4. Consider uploading reports for the commit 3d9bfe4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14872      +/-   ##
==========================================
- Coverage   66.52%   66.52%   -0.01%     
==========================================
  Files         931      931              
  Lines       75153    75159       +6     
  Branches     2203     2203              
==========================================
- Hits        49999    49996       -3     
- Misses      21276    21283       +7     
- Partials     3878     3880       +2     
Flag Coverage Δ
unittests 66.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/server/middleware/security/v2_token.go 53.57% <0.00%> (-6.43%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 47.00% <0.00%> (-5.99%) ⬇️
src/server/middleware/security/robot.go 25.80% <0.00%> (-2.77%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 24.35% <0.00%> (+1.28%) ⬆️
src/controller/event/topic.go 10.81% <0.00%> (+1.80%) ⬆️
src/common/utils/passports.go 89.74% <0.00%> (+5.12%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 61.11% <0.00%> (+5.55%) ⬆️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️

Signed-off-by: wang yan <[email protected]>
@wy65701436
Copy link
Contributor Author

wy65701436 commented May 14, 2021

Got one problem on Notary, it may need to modify notary to support go 1.16.

golang/go#41089

May 13 16:04:30 172.18.0.1 notary-signer[6207]: crypto/hmac.New(0xc0001190c8, 0xc000029dd0, 0x8, 0x8, 0x0, 0x8)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/usr/local/go/src/crypto/hmac/hmac.go:143 +0x370
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go/kdf.DerivePBKDF2(0xc000029dd0, 0x8, 0x8, 0xc000027b90, 0x1f, 0x30, 0x2000, 0x80, 0xb6faf8, 0xc000097f00, ...)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go/kdf/pbkdf2.go:15 +0xad
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go.(*Pbse2HmacAesKW).WrapNewKey(0xc00013a4f8, 0x100, 0x9d6160, 0xc000375930, 0xc0003ac0f0, 0x1, 0xc000375920, 0x8, 0x0, 0xc000375920, ...)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go/pbse2_hmac_aeskw.go:50 +0x439
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go.encrypt(0xc000097e80, 0x79, 0x80, 0xc0003ac0f0, 0x9d6160, 0xc000375930, 0xc000097ef9, 0x7, 0x0, 0xc000097e80)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go/jose.go:308 +0x20a
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go.EncryptBytes(0xc000097e80, 0x79, 0x80, 0xaad1f7, 0x12, 0xaa469e, 0x7, 0x9d6160, 0xc000375930, 0x0, ...)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go/jose.go:225 +0x32f
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go.Encrypt(...)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/github.com/dvsekhvalnov/jose2go/jose.go:190
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/signer/keydbstore.(*SQLKeyDBStore).AddKey(0xc0000f2000, 0xc000029555, 0x9, 0xc000027620, 0x28, 0xb72628, 0xc000381bc0, 0xc000388410, 0xc000052888)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/signer/keydbstore/sql_keydbstore.go:80 +0x1db
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/signer/keydbstore.(*SQLKeyDBStore).Create(0xc0000f2000, 0xc000029555, 0x9, 0xc000027620, 0x28, 0xc000029550, 0x5, 0x0, 0x0, 0x0, ...)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/signer/keydbstore/sql_keydbstore.go:215 +0x36a
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/signer/api.(*KeyManagementServer).CreateKey(0xc000010058, 0x7f1ee21ae8d0, 0xc00038b0b0, 0xc00038b1d0, 0xc000010058, 0x0, 0xc000052c40)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/signer/api/rpc_api.go:43 +0x13e
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/proto._KeyManagement_CreateKey_Handler(0xa10dc0, 0xc000010058, 0x7f1ee21ae8d0, 0xc00038b0b0, 0xc00036fe00, 0x0, 0x0, 0x0, 0x0, 0x0)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/proto/signer.pb.go:348 +0x214
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/google.golang.org/grpc.(*Server).processUnaryRPC(0xc0000f20c0, 0xb72808, 0xc0000816c0, 0xc000377800, 0xc000021650, 0xead600, 0xc00038b170, 0x0, 0x0)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/google.golang.org/grpc/server.go:708 +0x8dd
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/google.golang.org/grpc.(*Server).handleStream(0xc0000f20c0, 0xb72808, 0xc0000816c0, 0xc000377800, 0xc00038b170)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/google.golang.org/grpc/server.go:892 +0xf1d
May 13 16:04:30 172.18.0.1 notary-signer[6207]: github.com/theupdateframework/notary/vendor/google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc000028830, 0xc0000f20c0, 0xb72808, 0xc0000816c0, 0xc000377800)
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/google.golang.org/grpc/server.go:468 +0xab
May 13 16:04:30 172.18.0.1 notary-signer[6207]: created by github.com/theupdateframework/notary/vendor/google.golang.org/grpc.(*Server).serveStreams.func1
May 13 16:04:30 172.18.0.1 notary-signer[6207]: #011/go/src/github.com/theupdateframework/notary/vendor/google.golang.org/grpc/server.go:466 +0xa5
May 13 16:04:31 172.18.0.1 notary-signer[6207]: 2021/05/13 16:04:31 Updating database.
May 13 16:04:31 172.18.0.1 notary-signer[6207]: 2021/05/13 16:04:31 schema_migrations table does not require update, skip.

@wy65701436 wy65701436 changed the title upgrade golang to 1.16 [WIP] upgrade golang to 1.16 May 14, 2021
@reasonerjt
Copy link
Contributor

in v2.3 we'll use go 1.15.x

@reasonerjt reasonerjt closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants