fix artifact page bug (#19807)

* fix artifact page bug * update testcase
goharbor · Jan 15, 2024 · 04a1403 · 04a1403
1 parent eb12541
commit 04a1403
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/...-list-page/artifact-list/artifact-list-tab/artifact-filter/artifact-filter.component.html b/...-list-page/artifact-list/artifact-list-tab/artifact-filter/artifact-filter.component.html
@@ -83,6 +83,7 @@
                         (clickLabel)="selectValue($event)"
                         [scope]="'p'"
                         [projectId]="projectId"
+                        [dropdownOpened]="dropdownOpened"
                         [width]="200"
                         [ownedLabels]="getSelectLabel()">
                     </app-label-selector>

diff --git a/src/portal/src/app/shared/components/label-selector/label-selector.component.spec.ts b/src/portal/src/app/shared/components/label-selector/label-selector.component.spec.ts
@@ -59,6 +59,6 @@ describe('LabelSelectorComponent', () => {
         fixture.detectChanges();
         await fixture.whenStable();
         const checkIcon = fixture.nativeElement.querySelector('.check-icon');
-        expect(checkIcon.style.visibility).toEqual('visible');
+        expect(checkIcon.style.visibility).toEqual('hidden');
     });
 });
diff --git a/src/portal/src/app/shared/components/label-selector/label-selector.component.ts b/src/portal/src/app/shared/components/label-selector/label-selector.component.ts
@@ -41,6 +41,8 @@ export class LabelSelectorComponent implements OnInit, OnChanges, OnDestroy {
     scope: string = GLOBAL; // 'g' for global and 'p' for project, default 'g'
     @Input()
     projectId: number; // if scope = 'p', projectId is required
+    @Input()
+    dropdownOpened: boolean; // parent component opened status
     candidateLabels: Label[] = [];
     searchValue: string;
     loading: boolean = false;
@@ -159,7 +161,7 @@ export class LabelSelectorComponent implements OnInit, OnChanges, OnDestroy {
     isSelect(label: Label): boolean {
         if (this.ownedLabels?.length) {
             return this.ownedLabels.some(item => {
-                return item.id === label.id;
+                return item.id === label.id && this.dropdownOpened;
             });
         }
         return false;