-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for trivy dbRepository and javaDBRepository #1857
base: main
Are you sure you want to change the base?
Conversation
8d0b19c
to
e0582ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you point me to the upstream Trviy documentation?
I can't find anything related to SCANNER_TRIVY_DB_REPOSITORY
in trivy.
Here is the documentation for |
I will add support for multiple database repositories and mark the pull request as ready along with goharbor/harbor-scanner-trivy#7 as soon as trivy has decided which repositories to put as default. |
9513f87
to
9625b00
Compare
Signed-off-by: Benjamin Bordes <[email protected]> # Conflicts: # README.md
Signed-off-by: Benjamin Bordes <[email protected]>
9625b00
to
7b460f1
Compare
# | ||
# OCI repository(ies) to retrieve the trivy vulnerability database in order of priority | ||
dbRepository: | ||
- "mirror.gcr.io/aquasec/trivy-db" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add only the ghcr registry as default one and skip the mirror one?
- "ghcr.io/aquasecurity/trivy-db" | ||
# OCI repository(ies) to retrieve the Java trivy vulnerability database in order of priority | ||
javaDBRepository: | ||
- "mirror.gcr.io/aquasec/trivy-java-db" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
This adds support for custom trivy
dbRepository
andjavaDBRepository
which was made possible throughSCANNER_TRIVY_DB_REPOSITORY
andSCANNER_TRIVY_JAVA_DB_REPOSITORY
environment variables added in goharbor/harbor-scanner-trivy/pull/3.Closes #1821