Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table display on all commands #300

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Standing-Man
Copy link
Contributor

@Standing-Man Standing-Man commented Jan 1, 2025

fixed #304 and PR #286

fixed all commands that use table display.

current problem

image

after

image

Hi @Vad1mo and @bupd, Due to updates in the Bubble Tea framework, if the table height is set to the length of the rows, an error may occur. When the table contains only one row of data, it will display only the header. Therefore, we need to add an additional row of data to properly display the actual data.

It has been observed that any table with only one row of data encounters display issues.

@Standing-Man Standing-Man changed the title table display on artifact list table display on all commands Jan 2, 2025
@bupd
Copy link
Contributor

bupd commented Jan 9, 2025

@Standing-Man Can you check all commands such as view list and so.
Also add some screenshots for the view command

Thanks

@Standing-Man
Copy link
Contributor Author

For all view and list commands, they share the same table model for display, which is why they encounter the same issue with table presentation.
harbor project view
image

after fix this issue.
image
@bupd

@Standing-Man
Copy link
Contributor Author

ready to review. @Vad1mo @bupd

Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do rebase

bupd and others added 8 commits February 5, 2025 10:27
* add: auto man documentation generate scripts

Signed-off-by: bupd <[email protected]>

add: auto documentation generate scripts

Signed-off-by: bupd <[email protected]>

* remove md_doc generation & add man docs

Signed-off-by: bupd <[email protected]>

* update dagger for generating man pages

Signed-off-by: bupd <[email protected]>

* update github workflow

Signed-off-by: bupd <[email protected]>

* update man doc generation

Signed-off-by: bupd <[email protected]>

* add cli and man docs

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

* move man pages to man1

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
* Added first version of Makefile; include ldflags; tests, dependencies

Signed-off-by: Patrick Eschenbach <[email protected]>

* Added ldflags to build dagger functions

Signed-off-by: Patrick Eschenbach <[email protected]>

* Added requested changes in PR: Removed System flag; Removed prod fallback version; Fixed dev version to static version

Signed-off-by: Patrick Eschenbach <[email protected]>

* Added requested changes in PR: Removed System flag; Removed prod fallback version; Fixed dev version to static version; Removed bin files

Signed-off-by: Patrick Eschenbach <[email protected]>

* removes harbor-dev binary file

Signed-off-by: bupd <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>

* imporvment

Signed-off-by: Patrick Eschenbach <[email protected]>

* refactor build and build-dev

Signed-off-by: Patrick Eschenbach <[email protected]>

---------

Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: bupd <[email protected]>
Co-authored-by: bupd <[email protected]>
Co-authored-by: Vadim Bauer <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
…ds. (goharbor#77)

* Added the missing options in some commands and refactored some commands.

Added missing parameters in the (1) go client list function of the `repo` and `user` commands
(2) go client getLogs function of the `logs.go` file in project command
using options.
Added the `XIsResourceName` parameter for the `GetProjectParams` function. And refactored the `view.go` file of project command.
Refactored the `view.go` file of registry command: accessing the `credentialName`.

Signed-off-by: muaz-32 <[email protected]>

* remove inconsistencies

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: muaz-32 <[email protected]>
Signed-off-by: bupd <[email protected]>
Co-authored-by: bupd <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
* configure linter

Signed-off-by: bupd <[email protected]>

* fix lint whitespace

Signed-off-by: bupd <[email protected]>

* update

Signed-off-by: bupd <[email protected]>

* add headers

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

* fix workflow

Signed-off-by: bupd <[email protected]>

* add debug in workflow

Signed-off-by: bupd <[email protected]>

* check lint

Signed-off-by: bupd <[email protected]>

* update actions summary

Signed-off-by: bupd <[email protected]>

* fix action

Signed-off-by: bupd <[email protected]>

* lint format github actions

Signed-off-by: bupd <[email protected]>

* stop upload result to github

Signed-off-by: bupd <[email protected]>

* upload lint report as html

Signed-off-by: bupd <[email protected]>

* check if html works

Signed-off-by: bupd <[email protected]>

* remove reviewdog and report in github actions format

Signed-off-by: bupd <[email protected]>

* fail lint

Signed-off-by: bupd <[email protected]>

* fix lint

Signed-off-by: bupd <[email protected]>

* fix lint

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
* fix publish & release workflow

* This commit fixes
* publish on push to main
* release on push tags

Signed-off-by: bupd <[email protected]>

* update yaml

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
@Standing-Man
Copy link
Contributor Author

PTAL @bupd @Vad1mo

@Standing-Man Standing-Man requested a review from bupd February 5, 2025 02:31
Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions

Please fix git commit history on this PR.

@Standing-Man
Copy link
Contributor Author

Thanks for your contributions

Please fix git commit history on this PR.

Hi @bupd, I resolved the git history issue by submitting PR #329.

@Standing-Man Standing-Man requested a review from bupd February 11, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Behaviour: Empty output in project view cmd
5 participants