Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoGenerate credential name in login #250

Merged
merged 5 commits into from
Nov 14, 2024
Merged

AutoGenerate credential name in login #250

merged 5 commits into from
Nov 14, 2024

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Nov 12, 2024

Fix #37

Summary

  • Adds autogeneration of credential name
  • update workflows for failing tests
  • Add password-stdin flag.

@bupd bupd added the Priority: Critical Impacts essential functionality, degrading the user experie label Nov 12, 2024
@bupd bupd changed the title AutoGenerate credential name AutoGenerate credential name in login Nov 13, 2024
karanngi and others added 2 commits November 13, 2024 11:32
- fixes dependencies

Signed-off-by: bupd <[email protected]>
@bupd
Copy link
Contributor Author

bupd commented Nov 13, 2024

cherry picked "--password-stdin commit" from pr #146

@bupd bupd force-pushed the fix-cred branch 5 times, most recently from b00bb2a to a3260d6 Compare November 13, 2024 07:07
Signed-off-by: bupd <[email protected]>
@bupd
Copy link
Contributor Author

bupd commented Nov 13, 2024

ready to merge!

@Vad1mo Vad1mo merged commit b2fb70f into goharbor:main Nov 14, 2024
5 checks passed
Standing-Man pushed a commit to Standing-Man/harbor-cli that referenced this pull request Nov 20, 2024
* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Standing-Man pushed a commit to Standing-Man/harbor-cli that referenced this pull request Nov 20, 2024
* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Standing-Man pushed a commit to Standing-Man/harbor-cli that referenced this pull request Nov 20, 2024
* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Signed-off-by: JianMinTang <[email protected]>
Standing-Man pushed a commit to Standing-Man/harbor-cli that referenced this pull request Nov 20, 2024
* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Signed-off-by: JianMinTang <[email protected]>
Vad1mo added a commit that referenced this pull request Nov 26, 2024
* Support yaml output for 'registry list'

Signed-off-by: JianMinTang <[email protected]>

* Use gofmt to format all code

Signed-off-by: JianMinTang <[email protected]>

* fix: Support YAML output for additional commands

Signed-off-by: JianMinTang <[email protected]>

* fix: Support YAML format on artiface and repo command

Signed-off-by: JianMinTang <[email protected]>

* fix: Implement a generic function to format output

Signed-off-by: JianMinTang <[email protected]>

* chore: fix the problem about golangci-lint

Signed-off-by: JianMinTang <[email protected]>

* AutoGenerate credential name in login (#250)

* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Signed-off-by: JianMinTang <[email protected]>

* print test output to screen (#254)

print test output to screen

Signed-off-by: JianMinTang <[email protected]>

* Support table format for repo view and add some comments on repo list

Signed-off-by: JianMinTang <[email protected]>

Add more detail on repo view

Signed-off-by: JianMinTang <[email protected]>

Support table format on registry view

Signed-off-by: JianMinTang <[email protected]>

Support table format on project view

Signed-off-by: JianMinTang <[email protected]>

Fixed tags list

Signed-off-by: JianMinTang <[email protected]>

Support table format and YAML/JSON output on artifact view

Signed-off-by: JianMinTang <[email protected]>

Fixed alignment problem

Signed-off-by: JianMinTang <[email protected]>

Fixed the code format

Signed-off-by: JianMinTang <[email protected]>

* AutoGenerate credential name in login (#250)

* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Signed-off-by: JianMinTang <[email protected]>

* print test output to screen (#254)

print test output to screen

Signed-off-by: JianMinTang <[email protected]>

* Support yaml output for 'registry list'

Signed-off-by: JianMinTang <[email protected]>

Use gofmt to format all code

Signed-off-by: JianMinTang <[email protected]>

fix: Support YAML output for additional commands

Signed-off-by: JianMinTang <[email protected]>

fix: Implement a generic function to format output

Signed-off-by: JianMinTang <[email protected]>

chore: fix the problem about golangci-lint

Signed-off-by: JianMinTang <[email protected]>

---------

Signed-off-by: JianMinTang <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: Prasanth B <[email protected]>
Co-authored-by: karanngi <[email protected]>
Co-authored-by: Vadim Bauer <[email protected]>
qcserestipy pushed a commit to qcserestipy/harbor-cli that referenced this pull request Dec 22, 2024
* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
qcserestipy pushed a commit to qcserestipy/harbor-cli that referenced this pull request Dec 22, 2024
* Support yaml output for 'registry list'

Signed-off-by: JianMinTang <[email protected]>

* Use gofmt to format all code

Signed-off-by: JianMinTang <[email protected]>

* fix: Support YAML output for additional commands

Signed-off-by: JianMinTang <[email protected]>

* fix: Support YAML format on artiface and repo command

Signed-off-by: JianMinTang <[email protected]>

* fix: Implement a generic function to format output

Signed-off-by: JianMinTang <[email protected]>

* chore: fix the problem about golangci-lint

Signed-off-by: JianMinTang <[email protected]>

* AutoGenerate credential name in login (goharbor#250)

* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Signed-off-by: JianMinTang <[email protected]>

* print test output to screen (goharbor#254)

print test output to screen

Signed-off-by: JianMinTang <[email protected]>

* Support table format for repo view and add some comments on repo list

Signed-off-by: JianMinTang <[email protected]>

Add more detail on repo view

Signed-off-by: JianMinTang <[email protected]>

Support table format on registry view

Signed-off-by: JianMinTang <[email protected]>

Support table format on project view

Signed-off-by: JianMinTang <[email protected]>

Fixed tags list

Signed-off-by: JianMinTang <[email protected]>

Support table format and YAML/JSON output on artifact view

Signed-off-by: JianMinTang <[email protected]>

Fixed alignment problem

Signed-off-by: JianMinTang <[email protected]>

Fixed the code format

Signed-off-by: JianMinTang <[email protected]>

* AutoGenerate credential name in login (goharbor#250)

* generate credential name

Signed-off-by: bupd <[email protected]>

* feat: add support for the password-stdin flag in login flow

Signed-off-by: karanngi <[email protected]>

* fix deps

- fixes dependencies

Signed-off-by: bupd <[email protected]>

* return stdout for tests

Signed-off-by: bupd <[email protected]>

* update workflow

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: karanngi <[email protected]>
Signed-off-by: JianMinTang <[email protected]>

* print test output to screen (goharbor#254)

print test output to screen

Signed-off-by: JianMinTang <[email protected]>

* Support yaml output for 'registry list'

Signed-off-by: JianMinTang <[email protected]>

Use gofmt to format all code

Signed-off-by: JianMinTang <[email protected]>

fix: Support YAML output for additional commands

Signed-off-by: JianMinTang <[email protected]>

fix: Implement a generic function to format output

Signed-off-by: JianMinTang <[email protected]>

chore: fix the problem about golangci-lint

Signed-off-by: JianMinTang <[email protected]>

---------

Signed-off-by: JianMinTang <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: karanngi <[email protected]>
Co-authored-by: Prasanth B <[email protected]>
Co-authored-by: karanngi <[email protected]>
Co-authored-by: Vadim Bauer <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical Impacts essential functionality, degrading the user experie
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harbor Login, Name of Credential should not be mandatory
3 participants