Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: be tolerant to implicit submodules #90

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Feb 14, 2023

Describe the pull request

Git itself allows adding another Git repository inside the current repository without properly defining as a submodule, so we need to be tolerant about that.

Link to the issue: gogs/gogs#6436

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #90 (f9d8e38) into master (8eac762) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   83.64%   83.68%   +0.04%     
==========================================
  Files          28       28              
  Lines        1785     1784       -1     
==========================================
  Hits         1493     1493              
+ Misses        177      176       -1     
  Partials      115      115              

@unknwon unknwon merged commit 7f9509a into master Feb 14, 2023
@unknwon unknwon deleted the jc/implicit-submodules branch February 14, 2023 06:35
@unknwon
Copy link
Member Author

unknwon commented Feb 14, 2023

https://github.com/gogs/git-module/releases/tag/v1.8.1 has been published for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant