Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for error before reading parent #84

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

aymanbagabas
Copy link
Contributor

Describe the pull request

Trying to get the commit's parent without checking for errors. Causing charmbracelet/soft-serve#177 in Soft Serve.

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #84 (59706f2) into master (34a6ca3) will decrease coverage by 0.28%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   83.47%   83.18%   -0.29%     
==========================================
  Files          27       27              
  Lines        1731     1737       +6     
==========================================
  Hits         1445     1445              
- Misses        176      179       +3     
- Partials      110      113       +3     

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon merged commit 58d9f16 into gogs:master Oct 31, 2022
@unknwon
Copy link
Member

unknwon commented Oct 31, 2022

https://github.com/gogs/git-module/releases/tag/v1.7.1 has been created for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants