Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo_blob): add CatFileBlob #79

Merged
merged 8 commits into from
Jun 25, 2022

Conversation

jonatan5524
Copy link
Contributor

@jonatan5524 jonatan5524 commented Jun 11, 2022

Describe the pull request

Add a method that returns any Blob object by its corresponding hash.

Link to the issue: gogs/gogs#5979

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@unknwon unknwon self-requested a review June 14, 2022 01:27
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #79 (03c927c) into master (9163d15) will decrease coverage by 0.08%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   83.39%   83.30%   -0.09%     
==========================================
  Files          26       27       +1     
  Lines        1704     1731      +27     
==========================================
+ Hits         1421     1442      +21     
- Misses        177      180       +3     
- Partials      106      109       +3     

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just one problem.

repo_blob.go Outdated Show resolved Hide resolved
repo_blob_test.go Outdated Show resolved Hide resolved
repo_blob_test.go Outdated Show resolved Hide resolved
repo_blob.go Show resolved Hide resolved
repo_blob_test.go Outdated Show resolved Hide resolved
repo_blob_test.go Show resolved Hide resolved
repo_blob.go Outdated Show resolved Hide resolved
repo_blob_test.go Show resolved Hide resolved
@unknwon
Copy link
Member

unknwon commented Jun 23, 2022

Thanks for the followup!

repo_blob.go Outdated Show resolved Hide resolved
repo_blob.go Outdated Show resolved Hide resolved
repo_blob.go Outdated Show resolved Hide resolved
repo_blob.go Outdated Show resolved Hide resolved
@unknwon
Copy link
Member

unknwon commented Jun 23, 2022

There are too many compile errors... could you fix that?

@jonatan5524
Copy link
Contributor Author

There are too many compile errors... could you fix that?

yes, I am not working from home, working from web, because of that there are errors, I will take care of it.

@jonatan5524
Copy link
Contributor Author

fixed the compile errors @unknwon , sorry for the delay and the bad work, I had a busy week and could work on it properly only now.

@unknwon
Copy link
Member

unknwon commented Jun 24, 2022

No worries at all! I’ll take another look, thanks!

@unknwon unknwon merged commit 2f21148 into gogs:master Jun 25, 2022
@unknwon
Copy link
Member

unknwon commented Jun 25, 2022

https://github.com/gogs/git-module/releases/tag/v1.7.0 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants