Release 1.8.0 rc2 #914
Merged
Release 1.8.0 rc2 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapting block.timepoint to the new form also adapts withdrawal_block_timepoint, deposit_block_timepoint, and stake_block_timepoint, which must all be equal to block.timepoint.
The global state should have the last_finalized_timepoint equal to the input.since, do not add the finality_time_in_ms.
fix error: binary `ckb-binary-patcher` already exists in destination
…ises#905) * refactor: move `gw-types` and `gw-common` to `gwos` folder * fix(ci): install nightly rustfmt * fix: prevent to get a early since value in global_state_last_finalized_timepoint_to_since * fix(ci): script-tests c-uint256-tests * refactor: move smt from `gw-common` to a standalone crate `gw-smt` * refactor: remove tron account lock contract * chore: remove unused step from CI * refactor: define H256 as alias of [u8; 32] * refactor: remove unused files from gw-smt * refactor: reduce copy when convert Vec<SMTH256> * fix(ci): fix molecule schema url * fix: fix evm tests * fix: gwos-evm tests
If a CKB indexer RPC url is explicitly specified, we assume that we are connecting to a standalone indexer (i.e. we use `get_tip`). Otherwise we just use CKB RPC url and assume that we are connecting to CKB builtin indexer (i.e. we use `get_indexer_tip`).
Molecule: - `CustodianLockArgs#deposit_block_timepoint` -> `deposit_finalized_timepoint` - `WithdrawalLockArgs#withdrawal_block_timepoint` -> `withdrawal_finalized_timepoint` - `StakeLockArgs#stake_block_timepoint` -> `stake_finalized_timepoint` JronRPC: - `WithdrawalLockArgs#withdrawal_block_timepoint` -> `withdrawal_finalized_timepoint`
jjyr
force-pushed
the
release-1.8.0-rc2
branch
from
7162b81 to
02de4dc
Compare
Flouse
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[v1.8.0-rc2] - 2022-12-19
A major change in this release is re-interpreting the meaning of the
xxx_timepointfield tofinalized timestamp.Thus, we can use the CKB transaction's
sincefield to determine the l1 timestamp and to unlock l1 cells without reference to the Rollup cell. It also simplifies the finality determination of withdrawal cells.We also adjust the documentation:
Other changes: